This repository has been archived by the owner on May 15, 2023. It is now read-only.
Add 3 default_route_action subfields to google_compute_region_url_map resource
#1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…map` resource (#6674) * Add `defaultRouteAction.weightedBackendServices[]` to `google_compute_region_url_map` resource Enforce mutual exclusive relationships between `defaultRouteAction.weightedBackendServices[]`, `defaultUrlRedirect` and `defaultService` * Add generated test for `google_compute_region_url_map` resource, including `defaultRouteAction.weightedBackendServices[]` * Add `defaultRouteAction.retryPolicy` to `google_compute_region_url_map` resource, update generated test * Add `defaultRouteAction.requestMirrorPolicy` to `google_compute_region_url_map` resource, update generated test * Add missing field descriptions * Add missing `properties` field from `requestMirrorPolicy` definition * Update example (an generated tests) to have multiple `weighted_backend_services` blocks and nested blocks * Convert `defaultRouteAction.weightedBackendServices` and `defaultRouteAction.weightedBackendServices.headerAction.*` lists to sets, add test showing issue with permadiff * Remove use of sets, to match global version of the resource * Add `conflicts` field between `default_url_redirect` and `default_route_action` To match UrlMap resource : https://github.com/hashicorp/magic-modules/blob/4f1ef3974f99d6a9efa95ea0284ee831cc63d2f5/mmv1/products/compute/api.yaml#L18556-L18557 * Remove validation for field not added in this PR * Update acceptance test to set and update `retry_policy`, `request_mirror_policy`, and`weighted_backend_services` fields within `default_route_action` * Add missing `at_least_one_of` fields, for parity with the global version of this resource * Update `at_least_one_of` field to reference fields currently within `default_route_action`, add field to `retryPolicy` Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
melinath
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes hashicorp/terraform-provider-google#10660
This PR adds multiple new fields to the RegionUrlMap resource:
I've added the other fields under
defaultRouteAction, but wanted to split the work across 2 PRs so it was easier to reviewIf this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6674