Fix the following panic in aws security_group #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakazuki
force-pushed
the
fix_aws_security_group
branch
2 times, most recently
from
20f30de
to
a23e9e4
Compare
```
2022/09/29 18:34:28 aws importing... sg
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4d70abf]
goroutine 1 [running]:
github.com/GoogleCloudPlatform/terraformer/providers/aws.fromPort(...)
/home/runner/work/terraformer/terraformer/providers/aws/sg.go:362
```
sakazuki
force-pushed
the
fix_aws_security_group
branch
from
a23e9e4
to
870031a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IpPermission.IpProtocolcan get the value "-1"https://github.com/aws/aws-sdk-go-v2/blob/main/service/ec2/types/types.go#L7263-L7270
But when
IpPermission.IpProtocolis "-1" then, the following panic occurs