Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ionoscloud support #1600

Merged
merged 46 commits into from
Feb 7, 2023
Merged

Add Ionoscloud support #1600

merged 46 commits into from
Feb 7, 2023

Conversation

adeatcu-ionos
Copy link
Contributor

No description provided.

iblindu and others added 30 commits July 1, 2022 16:28
@google-cla
Copy link

google-cla bot commented Jan 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adeatcu-ionos adeatcu-ionos marked this pull request as draft January 6, 2023 10:20
@adeatcu-ionos adeatcu-ionos marked this pull request as ready for review January 13, 2023 14:27
@adeatcu-ionos
Copy link
Contributor Author

@sergeylanzman can you please take a look? thank you!

@@ -96,6 +96,8 @@ func RefreshResources(resources []*Resource, provider *providerwrapper.ProviderW

wg.Wait()
for _, r := range resources {
log.Printf("Instance state %v \n", r.InstanceState)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete, no need here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -106,6 +108,8 @@ func RefreshResources(resources []*Resource, provider *providerwrapper.ProviderW
for _, resourceGroup := range slowProcessingResources {
for i := range resourceGroup {
r := resourceGroup[i]
log.Printf("slow processing Instance state %v \n", r.InstanceState)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete, no need here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@sergeylanzman sergeylanzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete unused prints

@adeatcu-ionos
Copy link
Contributor Author

@MariaSu @sergeylanzman can you run the golangci-lint again, please? I looked into the previous outputs and I fixed all the errors that were related to our changes.

@adeatcu-ionos
Copy link
Contributor Author

@MariaSu @sergeylanzman the linter is passing now. It seems that everything is good from our side, thank you!

@sergeylanzman sergeylanzman merged commit 46e74d5 into GoogleCloudPlatform:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants