New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Alicloud provider and multiple services #239
Added Alicloud provider and multiple services #239
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!!!
3 comments:
- Please https://github.com/aliyun/alibaba-cloud-sdk-go instance provider, more light import
- You can use ID with name of instance
- Delete unused functions
bebc6ce
to
9ced4dd
Compare
Tell me ping, when you finished this PR. |
@sergeylanzman I have updated the README.md it is ready for merge. |
@Ghost---Shadow |
I have added ECS (EC2) service for alicloud platform. If things are looking good then I will start mass producing other services.
#170