Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Alicloud provider and multiple services #239

Merged
merged 23 commits into from Oct 17, 2019

Conversation

Ghost---Shadow
Copy link
Contributor

I have added ECS (EC2) service for alicloud platform. If things are looking good then I will start mass producing other services.

#170

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Ghost---Shadow
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@sergeylanzman sergeylanzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!!
3 comments:

  1. Please https://github.com/aliyun/alibaba-cloud-sdk-go instance provider, more light import
  2. You can use ID with name of instance
  3. Delete unused functions

cmd/alicloud.go Outdated Show resolved Hide resolved
providers/alicloud/ecs.go Outdated Show resolved Hide resolved
providers/alicloud/ecs.go Outdated Show resolved Hide resolved
providers/alicloud/ecs.go Outdated Show resolved Hide resolved
providers/alicloud/alicloud_service.go Show resolved Hide resolved
@sergeylanzman
Copy link
Collaborator

Tell me ping, when you finished this PR.

@Ghost---Shadow Ghost---Shadow changed the title Implemented ECS for alicloud Added Alicloud provider and multiple services Oct 17, 2019
@Ghost---Shadow
Copy link
Contributor Author

@sergeylanzman I have updated the README.md it is ready for merge.

@sergeylanzman
Copy link
Collaborator

@Ghost---Shadow
Thank for your contribution!
I will check after option don't import all AliCloud provider, but for now it's ok.

@sergeylanzman sergeylanzman merged commit 7242af2 into GoogleCloudPlatform:master Oct 17, 2019
@Ghost---Shadow Ghost---Shadow deleted the issue170 branch October 18, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants