Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DigitalOcean Projects Pagination #274

Merged
merged 1 commit into from Nov 7, 2019
Merged

Update DigitalOcean Projects Pagination #274

merged 1 commit into from Nov 7, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Nov 7, 2019

There was a bug in the DigitalOcean Go SDK where you were unable to use IsLastPage() to determine the last page for Projects so I originally used a workaround, but that has been fixed in v1.24.1 so I updated the godo version and refactored the Projects code to use IsLastPage().

@sergeylanzman sergeylanzman merged commit 0b48391 into GoogleCloudPlatform:master Nov 7, 2019
@aqche aqche deleted the digitalocean_projects_pagination branch November 7, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants