Stabilize GKE related flags

[arvindbr8]

As part of the next release, we want to stabilize flags that were introduced as part of CSM release and have been tested. The shape of these flags are not expected to change since they define very specific GKE / CSM related attributes. The flags that are stabilize are the following:

• gke-cluster-name
• config-mesh
• generate-mesh-id

I tested to make sure we have backwards compatibility to the -experimental flags.

Test details

Project name: arvindbright-k8n-test

Cluster name: arvindbright-test-ssa

Pod name: psm-grpc-client-8568fccdc6-44qht

root@psm-grpc-client-8568fccdc6-44qht:/traffic-director-grpc-bootstrap# ./td-grpc-bootstrap --generate-mesh-id
{
  "xds_servers": [
    {
      "server_uri": "trafficdirector.googleapis.com:443",
      "channel_creds": [
        {
          "type": "google_default"
        }
      ],
      "server_features": [
        "xds_v3"
      ]
    }
  ],
  "authorities": {
    "traffic-director-c2p.xds.googleapis.com": {
      "xds_servers": [
        {
          "server_uri": "dns:///directpath-pa.googleapis.com",
          "channel_creds": [
            {
              "type": "google_default"
            }
          ],
          "server_features": [
            "xds_v3",
            "ignore_resource_deletion"
          ]
        }
      ],
      "client_listener_resource_name_template": "xdstp://traffic-director-c2p.xds.googleapis.com/envoy.config.listener.v3.Listener/%s"
    }
  },
  "node": {
    "id": "projects/439293274322/networks/mesh:gsmmesh-b0qq-arvindbright-test-ssa-us-west1-c-b0qq2zt1szea/nodes/4a939aaa-c2db-4f27-8d46-c33553c87231",
    "cluster": "cluster",
    "metadata": {
      "INSTANCE_IP": "10.124.0.12",
      "TRAFFICDIRECTOR_GRPC_BOOTSTRAP_GENERATOR_SHA": "9eb89f3abcd49dd156c6e33f238786257c8326d8"
    },
    "locality": {
      "zone": "us-west1-c"
    }
  },
  "certificate_providers": {
    "google_cloud_private_spiffe": {
      "plugin_name": "file_watcher",
      "config": {
        "certificate_file": "/var/run/secrets/workload-spiffe-credentials/certificates.pem",
        "private_key_file": "/var/run/secrets/workload-spiffe-credentials/private_key.pem",
        "ca_certificate_file": "/var/run/secrets/workload-spiffe-credentials/ca_certificates.pem",
        "refresh_interval": "600s"
      }
    }
  },
  "server_listener_resource_name_template": "grpc/server?xds.resource.listening_address=%s"
}

root@psm-grpc-client-8568fccdc6-44qht:/traffic-director-grpc-bootstrap# ./td-grpc-bootstrap --generate-mesh-id --gke-cluster-name something
{
  "xds_servers": [
    {
      "server_uri": "trafficdirector.googleapis.com:443",
      "channel_creds": [
        {
          "type": "google_default"
        }
      ],
      "server_features": [
        "xds_v3"
      ]
    }
  ],
  "authorities": {
    "traffic-director-c2p.xds.googleapis.com": {
      "xds_servers": [
        {
          "server_uri": "dns:///directpath-pa.googleapis.com",
          "channel_creds": [
            {
              "type": "google_default"
            }
          ],
          "server_features": [
            "xds_v3",
            "ignore_resource_deletion"
          ]
        }
      ],
      "client_listener_resource_name_template": "xdstp://traffic-director-c2p.xds.googleapis.com/envoy.config.listener.v3.Listener/%s"
    }
  },
  "node": {
    "id": "projects/439293274322/networks/mesh:gsmmesh-dgm2-something-us-west1-c-dgm2uazvapry/nodes/a9ae21c9-d249-45f4-b6aa-11226b40e82b",
    "cluster": "cluster",
    "metadata": {
      "INSTANCE_IP": "10.124.0.12",
      "TRAFFICDIRECTOR_GRPC_BOOTSTRAP_GENERATOR_SHA": "9eb89f3abcd49dd156c6e33f238786257c8326d8"
    },
    "locality": {
      "zone": "us-west1-c"
    }
  },
  "certificate_providers": {
    "google_cloud_private_spiffe": {
      "plugin_name": "file_watcher",
      "config": {
        "certificate_file": "/var/run/secrets/workload-spiffe-credentials/certificates.pem",
        "private_key_file": "/var/run/secrets/workload-spiffe-credentials/private_key.pem",
        "ca_certificate_file": "/var/run/secrets/workload-spiffe-credentials/ca_certificates.pem",
        "refresh_interval": "600s"
      }
    }
  },
  "server_listener_resource_name_template": "grpc/server?xds.resource.listening_address=%s"
}

root@psm-grpc-client-8568fccdc6-44qht:/traffic-director-grpc-bootstrap# ./td-grpc-bootstrap --generate-mesh-id-experimental
{
  "xds_servers": [
    {
      "server_uri": "trafficdirector.googleapis.com:443",
      "channel_creds": [
        {
          "type": "google_default"
        }
      ],
      "server_features": [
        "xds_v3"
      ]
    }
  ],
  "authorities": {
    "traffic-director-c2p.xds.googleapis.com": {
      "xds_servers": [
        {
          "server_uri": "dns:///directpath-pa.googleapis.com",
          "channel_creds": [
            {
              "type": "google_default"
            }
          ],
          "server_features": [
            "xds_v3",
            "ignore_resource_deletion"
          ]
        }
      ],
      "client_listener_resource_name_template": "xdstp://traffic-director-c2p.xds.googleapis.com/envoy.config.listener.v3.Listener/%s"
    }
  },
  "node": {
    "id": "projects/439293274322/networks/mesh:gsmmesh-b0qq-arvindbright-test-ssa-us-west1-c-b0qq2zt1szea/nodes/5a7d864e-5de2-4339-9f4f-7330651529c5",
    "cluster": "cluster",
    "metadata": {
      "INSTANCE_IP": "10.124.0.12",
      "TRAFFICDIRECTOR_GRPC_BOOTSTRAP_GENERATOR_SHA": "9eb89f3abcd49dd156c6e33f238786257c8326d8"
    },
    "locality": {
      "zone": "us-west1-c"
    }
  },
  "certificate_providers": {
    "google_cloud_private_spiffe": {
      "plugin_name": "file_watcher",
      "config": {
        "certificate_file": "/var/run/secrets/workload-spiffe-credentials/certificates.pem",
        "private_key_file": "/var/run/secrets/workload-spiffe-credentials/private_key.pem",
        "ca_certificate_file": "/var/run/secrets/workload-spiffe-credentials/ca_certificates.pem",
        "refresh_interval": "600s"
      }
    }
  },
  "server_listener_resource_name_template": "grpc/server?xds.resource.listening_address=%s"
}

[ejona86]

LGTM