Flights #1
Merged
Flights #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gstripling
pushed a commit
that referenced
this pull request
Jun 11, 2020
Merge the base into master
philmaier
pushed a commit
that referenced
this pull request
Feb 2, 2022
GSP354 - vertex-challenge-lab.ipynb
hrishikesh-kadam
added a commit
to hrishikesh-kadam/training-data-analyst
that referenced
this pull request
Feb 28, 2022
Lab - https://www.cloudskillsboost.google/course_sessions/812316/labs/190664 Video - https://www.cloudskillsboost.google/course_sessions/812316/video/190665 Course - https://www.cloudskillsboost.google/course_templates/2 In the Lab, Task 4 needs the correction. Currently, the Task 4 is expected to fail but as below. Expected - ``` Finished Step GoogleCloudPlatform#1 ERROR ERROR: build step 1 "gcr.io/qwiklabs-gcp-04-9d788c36b0e6/quickstart-image" failed: step exited with non-zero status: 1 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ BUILD FAILURE: Build step failure: build step 1 "gcr.io/qwiklabs-gcp-04-9d788c36b0e6/quickstart-image" failed: step exited with non-zero status: 1 ``` The Task 4 is incorrectly failing due to the incorrect argument passed to the cloudbuild.yaml The arguments only contains the ['fail'] instead of the ['./quickstart.sh', 'fail'] As there is no mention of ENTRYPOINT in Dockerfile as well as in cloudbuild.yaml, the passed arguments overrides the CMD in the Dockerfile[1]. Also, I have updated the executable bit of all the quickstart.sh References - [1]: 4th Point of https://docs.docker.com/engine/reference/builder/#understand-how-cmd-and-entrypoint-interact
hrishikesh-kadam
added a commit
to hrishikesh-kadam/training-data-analyst
that referenced
this pull request
Feb 28, 2022
Lab - https://www.cloudskillsboost.google/course_sessions/812316/labs/190664 Video - https://www.cloudskillsboost.google/course_sessions/812316/video/190665 Course - https://www.cloudskillsboost.google/course_templates/2 In the Lab, Task 4 needs the correction. Currently, the Task 4 is expected to fail but as below. Expected - ``` Finished Step GoogleCloudPlatform#1 ERROR ERROR: build step 1 "gcr.io/qwiklabs-gcp-04-9d788c36b0e6/quickstart-image" failed: step exited with non-zero status: 1 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ BUILD FAILURE: Build step failure: build step 1 "gcr.io/qwiklabs-gcp-04-9d788c36b0e6/quickstart-image" failed: step exited with non-zero status: 1 ``` The Task 4 is incorrectly failing due to the incorrect argument passed to the cloudbuild.yaml The arguments only contains the ['fail'] instead of the ['./quickstart.sh', 'fail'] As there is no mention of ENTRYPOINT in Dockerfile as well as in cloudbuild.yaml, the passed arguments overrides the CMD in the Dockerfile[1]. I have also updated the executable bit of all the quickstart.sh As a suggestion in the Lab, I think it would have been more appropriate if after building and pushing the images to gcr.io, the Lab also teach about how to pull and run the images using docker command. References - [1]: 4th Point of https://docs.docker.com/engine/reference/builder/#understand-how-cmd-and-entrypoint-interact
hrishikesh-kadam
added a commit
to hrishikesh-kadam/training-data-analyst
that referenced
this pull request
Feb 28, 2022
Lab - https://www.cloudskillsboost.google/course_sessions/812316/labs/190664 Video - https://www.cloudskillsboost.google/course_sessions/812316/video/190665 Course - https://www.cloudskillsboost.google/course_templates/2 In the Lab, Task 4 needs the correction. Currently, the Task 4 is expected to fail but as below. Expected - ``` Finished Step GoogleCloudPlatform#1 ERROR ERROR: build step 1 "gcr.io/qwiklabs-gcp-04-9d788c36b0e6/quickstart-image" failed: step exited with non-zero status: 1 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ BUILD FAILURE: Build step failure: build step 1 "gcr.io/qwiklabs-gcp-04-9d788c36b0e6/quickstart-image" failed: step exited with non-zero status: 1 ``` The Task 4 is incorrectly failing due to the incorrect argument passed to the cloudbuild.yaml The arguments only contains the ['fail'] instead of the ['/quickstart.sh', 'fail'] As there is no mention of ENTRYPOINT in Dockerfile as well as in cloudbuild.yaml, the passed arguments overrides the CMD in the Dockerfile[1]. I have also updated the executable bit of all the quickstart.sh As a suggestion in the Lab, I think it would have been more appropriate if after building and pushing the images to gcr.io, the Lab also teach about how to pull and run the images using docker command. References - [1]: 4th Point of https://docs.docker.com/engine/reference/builder/#understand-how-cmd-and-entrypoint-interact
rosera
pushed a commit
that referenced
this pull request
Jan 13, 2023
aiplatform package installation, kernel restart code added
0yster
pushed a commit
that referenced
this pull request
Apr 18, 2023
Notebook Update: GSP013 - train_deploy.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapters 1-8