This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Confirm nothing breaks after rules_docker incompatible change #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will need to be merged after our rules_docker PR is merged. |
|
The current test error was fixed by something that was merged to master after this PR was created. Can you rebase so I can rerun the tests? |
alex1545
force-pushed
the
rules_docker-incompatible-change
branch
from
a7bf90c
to
96901b9
Compare
|
Can you please try again? |
|
This is no longer needed after #314 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_docker address this incompatible Bazel change in this PR.
This PR is the verify we don't break things in this project.