Added goroutine to watch namespaces and add secrets #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly return from `updateCheck()` if it errors, instead of possibly crashing the server - Updated dependencies - Added more docs to README including how to run locally
spowelljr
requested changes
Nov 28, 2022
spowelljr
reviewed
Nov 28, 2022
- inverted large if block and moved check to beginning of func - small readme fixes
spowelljr
requested changes
Nov 29, 2022
spowelljr
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long overdue bug where newly created namespaces do not include the image registry pull secret. I created an additional PR in the minikube repo to go along with this one.
To test:
Ensure you have the minikube changes as well.
$ minikube addons enable gcp-auth
$ kubectl create ns new-namespace
$ kubectl get secrets -n new-namespace
Before:
After:
Additional Changes:
updateCheck()if it errors, instead of possibly crashing the server