gcp-auth addon now adds the image registry pull secret to newly created namespaces #15403

iastewar · 2022-11-25T02:04:22Z

This should be merged after the webhook PR has been merged. Please see its description for more details.

linux-foundation-easycla · 2022-11-25T02:04:25Z

The committers listed above are authorized under a signed CLA.

✅ login: iastewar / name: Ian Stewart (3de8a8d)

k8s-ci-robot · 2022-11-25T02:04:30Z

Welcome @iastewar!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-11-25T02:04:30Z

Hi @iastewar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-11-25T02:05:05Z

Can one of the admins verify this patch?

spowelljr

Could you run make generate-docs to update the translations, thanks

pkg/addons/addons_gcpauth.go

spowelljr · 2022-11-29T21:13:15Z

/ok-to-test

spowelljr · 2022-11-29T21:14:11Z

Would you mind adding a small test to our GCP-Auth tests that creates a new namespace and ensures the secret is there?

minikube-pr-bot · 2022-11-29T23:04:27Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 55.0s    | 55.8s               |
| enable ingress | 27.9s    | 26.0s               |
+----------------+----------+---------------------+

Times for minikube start: 54.2s 55.1s 55.0s 55.0s 55.5s
Times for minikube (PR 15403) start: 55.7s 58.8s 54.2s 53.5s 56.9s

Times for minikube ingress: 28.7s 28.1s 25.2s 28.7s 28.7s
Times for minikube (PR 15403) ingress: 23.8s 27.7s 24.7s 25.2s 28.7s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15403) |
+-------------------+----------+---------------------+
| minikube start    | 26.4s    | 25.6s               |
| ⚠️  enable ingress | 21.0s    | 33.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 15403) start: 25.4s 24.5s 26.6s 27.0s 24.3s
Times for minikube start: 24.4s 29.0s 27.8s 25.5s 25.4s

Times for minikube ingress: 22.0s 20.5s 21.0s 21.5s 20.0s
Times for minikube (PR 15403) ingress: 22.5s 20.5s 81.9s 20.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 24.2s    | 23.6s               |
| enable ingress | 26.3s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 21.8s 21.8s 21.4s 33.9s 22.3s
Times for minikube (PR 15403) start: 25.1s 22.7s 24.7s 21.8s 23.5s

Times for minikube ingress: 26.0s 26.4s 26.4s 26.0s 26.5s
Times for minikube (PR 15403) ingress: 30.5s 25.9s 26.4s 26.0s 26.5s

minikube-pr-bot · 2022-11-30T01:04:46Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestAddons/serial/GCPAuth (gopogh)	0.00 (chart)
KVM_Linux	TestAddons/serial/GCPAuth (gopogh)	0.00 (chart)
KVM_Linux	TestKVMDriverInstallOrUpdate (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/NetCatPod (gopogh)	3.23 (chart)
Docker_Windows	TestMultiNode/serial/StartAfterStop (gopogh)	9.72 (chart)
Docker_Windows	TestPause/serial/Pause (gopogh)	9.77 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	21.53 (chart)
Hyperkit_macOS	TestPause/serial/SecondStartNoReconfiguration (gopogh)	26.35 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	26.87 (chart)
Docker_macOS	TestMultiNode/serial/RestartMultiNode (gopogh)	31.51 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	34.48 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	34.48 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	35.04 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	35.04 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	36.21 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	36.21 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	36.75 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	36.99 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	38.84 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	39.66 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	39.66 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	39.66 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	43.09 (chart)
KVM_Linux	TestMultiNode/serial/RestartMultiNode (gopogh)	44.52 (chart)
Docker_macOS	TestMultiNode/serial/RestartKeepsNodes (gopogh)	52.05 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	69.60 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	74.38 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	82.52 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	84.72 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

…l secret

iastewar · 2022-11-30T23:53:02Z

Would you mind adding a small test to our GCP-Auth tests that creates a new namespace and ensures the secret is there?

Done

minikube-pr-bot · 2022-12-01T02:28:55Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 53.8s    | 55.1s               |
| enable ingress | 27.1s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.2s 26.2s 28.7s 27.6s 27.6s
Times for minikube (PR 15403) ingress: 24.2s 27.6s 29.1s 27.7s 23.2s

Times for minikube start: 54.2s 53.4s 52.6s 54.4s 54.3s
Times for minikube (PR 15403) start: 54.4s 53.9s 54.4s 54.4s 58.6s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

minikube-pr-bot · 2022-12-02T09:50:32Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Hyperkit_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux_containerd	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
none_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux	TestFunctional/parallel/MountCmd/specific-port (gopogh)	0.00 (chart)
none_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	8.70 (chart)
Docker_macOS	TestNoKubernetes/serial/Start (gopogh)	10.45 (chart)
Docker_macOS	TestNoKubernetes/serial/StartNoArgs (gopogh)	10.45 (chart)
Docker_macOS	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	10.45 (chart)
Docker_macOS	TestNoKubernetes/serial/Stop (gopogh)	10.45 (chart)
Docker_macOS	TestNetworkPlugins/group/auto/Start (gopogh)	10.53 (chart)
Docker_macOS	TestNetworkPlugins/group/cilium/Start (gopogh)	10.53 (chart)
Docker_macOS	TestNetworkPlugins/group/false/Start (gopogh)	10.53 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/Stop (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	10.53 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh)	10.53 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-12-02T19:08:44Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 53.5s    | 53.6s               |
| enable ingress | 27.3s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube start: 53.6s 53.1s 53.5s 54.5s 52.6s
Times for minikube (PR 15403) start: 53.4s 52.6s 52.8s 54.1s 55.1s

Times for minikube ingress: 27.7s 27.1s 27.7s 28.1s 25.7s
Times for minikube (PR 15403) ingress: 24.7s 27.6s 28.7s 27.7s 23.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 26.3s               |
| enable ingress | 21.4s    | 21.3s               |
+----------------+----------+---------------------+

Times for minikube start: 28.2s 25.4s 25.3s 26.2s 26.3s
Times for minikube (PR 15403) start: 26.1s 26.5s 26.2s 25.9s 26.7s

Times for minikube ingress: 23.0s 20.5s 22.0s 22.0s 19.5s
Times for minikube (PR 15403) ingress: 21.5s 20.5s 22.0s 21.0s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 23.2s               |
| enable ingress | 26.2s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 23.3s 22.6s 21.8s 21.9s
Times for minikube (PR 15403) start: 24.6s 25.3s 21.7s 22.5s 21.8s

Times for minikube (PR 15403) ingress: 26.5s 26.0s 26.0s 26.0s 26.0s
Times for minikube ingress: 26.0s 26.0s 26.0s 27.0s 26.0s

iastewar · 2022-12-02T22:05:32Z

Seems like adding a timeout did not help unfortunately. Any other ideas why the test would be failing? Do you know if Jenkins is doing any image caching?

minikube-pr-bot · 2022-12-03T08:00:43Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Linux_containerd	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Hyperkit_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Hyper-V_Windows	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux_containerd	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
none_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Windows	TestPause/serial/Pause (gopogh)	9.09 (chart)
Docker_Windows	TestMultiNode/serial/StartAfterStop (gopogh)	9.52 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	13.61 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	28.17 (chart)
Docker_macOS	TestMultiNode/serial/RestartMultiNode (gopogh)	31.91 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	37.27 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	37.27 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	37.27 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	41.03 (chart)
Docker_macOS	TestMultiNode/serial/RestartKeepsNodes (gopogh)	55.32 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	70.54 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/NetCatPod (gopogh)	80.00 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	93.20 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	93.20 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	97.87 (chart)
Docker_Linux_containerd	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

…ugging

minikube-pr-bot · 2022-12-05T17:30:02Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 55.7s    | 55.2s               |
| enable ingress | 26.6s    | 26.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.7s 27.7s 28.1s 26.2s 28.2s
Times for minikube (PR 15403) ingress: 24.6s 27.2s 25.2s 27.7s 25.1s

Times for minikube start: 56.4s 55.3s 57.4s 54.7s 54.6s
Times for minikube (PR 15403) start: 55.1s 54.4s 55.4s 55.8s 55.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15403) |
+-------------------+----------+---------------------+
| minikube start    | 25.1s    | 26.6s               |
| ⚠️  enable ingress | 21.0s    | 26.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 20.9s 21.0s 23.0s 21.0s 19.4s
Times for minikube (PR 15403) ingress: 20.9s 49.5s 20.9s 20.0s 20.4s

Times for minikube start: 24.9s 24.7s 25.2s 25.6s 25.0s
Times for minikube (PR 15403) start: 28.9s 24.8s 24.6s 28.7s 26.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 23.3s               |
| enable ingress | 32.3s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 15403) start: 25.0s 22.4s 25.2s 22.1s 21.9s
Times for minikube start: 21.4s 22.4s 21.4s 21.9s 22.9s

Times for minikube ingress: 26.4s 57.4s 25.9s 26.0s 25.9s
Times for minikube (PR 15403) ingress: 26.4s 26.4s 26.4s 26.4s 26.4s

iastewar · 2022-12-05T17:44:00Z

Seems like adding a timeout did not help unfortunately. Any other ideas why the test would be failing? Do you know if Jenkins is doing any image caching?

Looking at the webhook container logs, it seems that the token cannot be fetched due to an authorization problem so I'll look into this further.

minikube-pr-bot · 2022-12-06T04:37:06Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	n/a
Hyperkit_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux_containerd	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
none_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	2.84 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	19.33 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	24.83 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	27.52 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	27.52 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

iastewar · 2022-12-06T15:42:32Z

Seems like adding a timeout did not help unfortunately. Any other ideas why the test would be failing? Do you know if Jenkins is doing any image caching?

Looking at the webhook container logs, it seems that the token cannot be fetched due to an authorization problem so I'll look into this further.

So the problem was actually an obvious one: the credentials are invalid. They are pulled in from test/integration/testdata/gcp-creds.json. Previously, the code didn't do anything if the token could not be retrieved as can be seen here. I changed this to return the error instead. Either way though this new test will fail since it is actually checking if the secret exists.

A few ideas:

Modify the webhook code to use a dummy token if the credentials are equal to the test credentials.
Use an env variable (or similar) to start the webhook in TEST mode. in this mode, token will be mocked.
Use real credentials.

Number 1 is the easiest and I am guessing we can't go with number 3. Thoughts?

spowelljr · 2022-12-07T19:16:45Z

1 & 2 both seem fine, 3 likely not

minikube-pr-bot · 2022-12-08T00:09:36Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 53.9s    | 53.5s               |
| enable ingress | 26.1s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 54.5s 54.4s 51.8s 56.1s 52.8s
Times for minikube (PR 15403) start: 52.1s 53.6s 53.8s 53.9s 54.4s

Times for minikube ingress: 24.2s 25.2s 24.7s 29.1s 27.2s
Times for minikube (PR 15403) ingress: 24.2s 27.7s 28.1s 23.2s 27.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 26.7s               |
| enable ingress | 21.4s    | 20.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.4s 21.5s 21.9s 21.0s 21.9s
Times for minikube (PR 15403) ingress: 22.0s 19.0s 20.9s 20.0s 19.4s

Times for minikube start: 25.6s 25.3s 25.8s 26.1s 26.1s
Times for minikube (PR 15403) start: 27.9s 25.3s 29.7s 25.2s 25.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.1s               |
| enable ingress | 26.8s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 22.3s 22.3s 22.6s 21.7s
Times for minikube (PR 15403) start: 21.2s 24.5s 21.4s 21.9s 21.3s

Times for minikube ingress: 26.4s 27.4s 27.5s 26.4s 26.5s
Times for minikube (PR 15403) ingress: 26.5s 25.9s 27.4s 26.4s 26.4s

minikube-pr-bot · 2022-12-08T09:47:34Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Linux_containerd	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestMultiNode/serial/StartAfterStop (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	n/a
Docker_Windows	TestPause/serial/Pause (gopogh)	n/a
Hyperkit_macOS	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Hyper-V_Windows	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux_containerd	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
KVM_Linux	TestAddons/serial/GCPAuth/Namespaces (gopogh)	n/a
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	11.81 (chart)
Docker_macOS	TestMultiNode/serial/RestartMultiNode (gopogh)	31.03 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	35.14 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	35.14 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	35.14 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	35.14 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	35.14 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	35.14 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	36.28 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	36.84 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	41.44 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	41.44 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	41.96 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

…r from images map. This should be moved.

minikube-pr-bot · 2022-12-08T20:11:53Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 53.9s    | 54.0s               |
| enable ingress | 25.3s    | 25.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.7s 23.7s 23.6s 23.6s 27.7s
Times for minikube (PR 15403) ingress: 24.1s 24.2s 24.1s 28.1s 27.7s

Times for minikube start: 54.0s 54.8s 54.6s 53.4s 52.6s
Times for minikube (PR 15403) start: 54.6s 53.2s 52.9s 55.6s 53.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 25.3s    | 26.4s               |
| enable ingress | 21.4s    | 21.4s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 25.5s 26.0s 26.6s 25.1s
Times for minikube (PR 15403) start: 27.0s 26.6s 26.0s 23.8s 28.3s

Times for minikube ingress: 21.5s 21.0s 22.5s 20.9s 21.0s
Times for minikube (PR 15403) ingress: 20.4s 19.4s 25.5s 19.5s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 24.3s               |
| enable ingress | 26.6s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.5s 27.4s 26.4s 26.5s 26.4s
Times for minikube (PR 15403) ingress: 26.0s 26.5s 26.4s 26.5s 26.4s

Times for minikube start: 21.9s 22.5s 21.5s 24.9s 25.3s
Times for minikube (PR 15403) start: 22.1s 21.8s 34.0s 21.8s 21.8s

minikube-pr-bot · 2022-12-08T23:39:45Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 55.7s    | 55.1s               |
| enable ingress | 28.4s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 15403) start: 55.3s 56.0s 54.2s 54.3s 55.8s
Times for minikube start: 54.3s 54.4s 58.7s 55.2s 55.9s

Times for minikube ingress: 28.7s 28.6s 28.2s 29.1s 27.6s
Times for minikube (PR 15403) ingress: 27.1s 27.7s 28.2s 27.7s 24.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 25.3s               |
| enable ingress | 26.7s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 26.4s 25.4s 25.3s 24.9s 25.8s
Times for minikube (PR 15403) start: 25.5s 24.7s 24.8s 25.6s 25.9s

Times for minikube ingress: 19.9s 20.9s 21.5s 21.5s 49.4s
Times for minikube (PR 15403) ingress: 22.0s 21.0s 19.5s 21.4s 48.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15403) |
+-------------------+----------+---------------------+
| minikube start    | 21.6s    | 22.2s               |
| ⚠️  enable ingress | 26.3s    | 32.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 26.4s 26.4s 26.0s 26.4s 26.4s
Times for minikube (PR 15403) ingress: 57.4s 26.4s 26.4s 25.9s 26.4s

Times for minikube start: 21.5s 21.4s 21.8s 21.5s 21.6s
Times for minikube (PR 15403) start: 21.0s 21.9s 20.9s 25.1s 21.9s

minikube-pr-bot · 2022-12-09T02:08:28Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	n/a
KVM_Linux	TestRunningBinaryUpgrade (gopogh)	0.66 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	0.66 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	0.66 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	6.54 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	7.75 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	8.45 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	9.63 (chart)
Docker_Linux	TestPause/serial/SecondStartNoReconfiguration (gopogh)	11.94 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	13.76 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	14.55 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	15.32 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	16.07 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	35.78 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	35.78 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	35.78 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	37.50 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	44.04 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	44.04 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	44.55 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	46.02 (chart)
Docker_macOS	TestMultiNode/serial/RestartKeepsNodes (gopogh)	60.56 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	67.86 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	71.64 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	80.60 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-12-09T05:21:17Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	n/a
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	1.82 (chart)
Docker_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	1.97 (chart)
Docker_macOS	TestMultiNode/serial/RestartKeepsNodes (gopogh)	60.84 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	67.86 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	69.35 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	71.64 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	80.60 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	82.84 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	82.84 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	86.57 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	96.33 (chart)
Docker_Linux_containerd	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

test/integration/addons_test.go

minikube-pr-bot · 2022-12-09T20:11:31Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 53.2s    | 54.1s               |
| enable ingress | 25.2s    | 24.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 23.6s 24.1s 28.6s 25.6s 24.1s
Times for minikube (PR 15403) ingress: 25.1s 24.1s 24.1s 24.1s 24.1s

Times for minikube start: 51.1s 54.5s 53.7s 53.9s 52.7s
Times for minikube (PR 15403) start: 55.1s 55.4s 53.0s 53.7s 53.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 25.7s               |
| enable ingress | 33.8s    | 20.9s               |
+----------------+----------+---------------------+

Times for minikube start: 28.3s 24.9s 28.0s 24.8s 25.3s
Times for minikube (PR 15403) start: 24.8s 24.6s 23.7s 29.7s 25.8s

Times for minikube (PR 15403) ingress: 19.9s 21.5s 20.9s 20.9s 21.0s
Times for minikube ingress: 82.9s 22.5s 21.9s 20.4s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15403) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 26.6s               |
| enable ingress | 26.4s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.4s 26.5s 26.4s 26.4s 26.4s
Times for minikube (PR 15403) ingress: 26.4s 26.4s 26.4s 26.4s 26.4s

Times for minikube start: 20.6s 21.7s 32.4s 21.2s 20.7s
Times for minikube (PR 15403) start: 21.3s 32.7s 21.8s 24.3s 33.0s

minikube-pr-bot · 2022-12-10T00:28:22Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	n/a
Docker_Windows	TestMultiNode/serial/StartAfterStop (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	n/a
Docker_Windows	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	n/a
Docker_Windows	TestPause/serial/Pause (gopogh)	n/a
Hyperkit_macOS	TestNoKubernetes/serial/Start (gopogh)	0.00 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	13.04 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	13.79 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	14.53 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	15.25 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	37.39 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	37.39 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	37.39 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	38.46 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	44.35 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	44.35 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	44.83 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	46.22 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	68.07 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	68.46 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	82.52 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	82.52 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	86.01 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/NetCatPod (gopogh)	95.12 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	96.52 (chart)
KVM_Linux	TestMultiNode/serial/ValidateNameConflict (gopogh)	98.89 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr

Looks good, thanks for the PR

k8s-ci-robot · 2022-12-14T21:50:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iastewar, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Moved image pull secret creation code to the webhook

3de8a8d

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 25, 2022

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2022

k8s-ci-robot requested review from afbjorklund and prezha November 25, 2022 02:05

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2022

iastewar mentioned this pull request Nov 25, 2022

Added goroutine to watch namespaces and add secrets GoogleContainerTools/gcp-auth-webhook#32

Merged

spowelljr requested changes Nov 28, 2022

View reviewed changes

pkg/addons/addons_gcpauth.go Outdated Show resolved Hide resolved

spowelljr mentioned this pull request Nov 29, 2022

Update GCP-Auth documentation before release #15420

Closed

iastewar added 2 commits November 29, 2022 15:46

updated GCPAuthWebhook image to v0.0.12

64d0c4e

addressed PR comments

6ee591c

iastewar requested review from spowelljr and removed request for prezha and afbjorklund November 29, 2022 20:56

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2022

added integration test to ensure new namespaces include the image pul…

bec22f0

…l secret

increased wait time for getting namespace secret

2c3ab40

returning gcp-auth container logs if namespace test fails to help deb…

a2ba24f

…ugging

added MOCK_GOOGLE_TOKEN env var

b76d247

iastewar and others added 2 commits December 8, 2022 13:46

Added MOCK_GOOGLE_TOKEN env var to gcp-auth container. Reading env va…

7b60a53

…r from images map. This should be moved.

Merge branch 'kubernetes:master' into gcp-auth-watch-namespaces

19249ea

Added Environment to the template data

44f8364

spowelljr requested changes Dec 9, 2022

View reviewed changes

test/integration/addons_test.go Outdated Show resolved Hide resolved

Using t.Setenv instead of os.Setenv

a6bfa55

iastewar requested a review from spowelljr December 13, 2022 17:21

spowelljr approved these changes Dec 14, 2022

View reviewed changes

spowelljr merged commit 455e334 into kubernetes:master Dec 14, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gcp-auth addon now adds the image registry pull secret to newly created namespaces #15403

gcp-auth addon now adds the image registry pull secret to newly created namespaces #15403

iastewar commented Nov 25, 2022

linux-foundation-easycla bot commented Nov 25, 2022 •

edited

k8s-ci-robot commented Nov 25, 2022

k8s-ci-robot commented Nov 25, 2022

minikube-bot commented Nov 25, 2022

spowelljr left a comment

spowelljr commented Nov 29, 2022

spowelljr commented Nov 29, 2022

minikube-pr-bot commented Nov 29, 2022

minikube-pr-bot commented Nov 30, 2022

iastewar commented Nov 30, 2022

minikube-pr-bot commented Dec 1, 2022

minikube-pr-bot commented Dec 2, 2022

minikube-pr-bot commented Dec 2, 2022

iastewar commented Dec 2, 2022

minikube-pr-bot commented Dec 3, 2022

minikube-pr-bot commented Dec 5, 2022

iastewar commented Dec 5, 2022

minikube-pr-bot commented Dec 6, 2022

iastewar commented Dec 6, 2022

spowelljr commented Dec 7, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 9, 2022

minikube-pr-bot commented Dec 9, 2022

minikube-pr-bot commented Dec 9, 2022

minikube-pr-bot commented Dec 10, 2022

spowelljr left a comment

k8s-ci-robot commented Dec 14, 2022

gcp-auth addon now adds the image registry pull secret to newly created namespaces #15403

gcp-auth addon now adds the image registry pull secret to newly created namespaces #15403

Conversation

iastewar commented Nov 25, 2022

linux-foundation-easycla bot commented Nov 25, 2022 • edited

k8s-ci-robot commented Nov 25, 2022

k8s-ci-robot commented Nov 25, 2022

minikube-bot commented Nov 25, 2022

spowelljr left a comment

Choose a reason for hiding this comment

spowelljr commented Nov 29, 2022

spowelljr commented Nov 29, 2022

minikube-pr-bot commented Nov 29, 2022

minikube-pr-bot commented Nov 30, 2022

iastewar commented Nov 30, 2022

minikube-pr-bot commented Dec 1, 2022

minikube-pr-bot commented Dec 2, 2022

minikube-pr-bot commented Dec 2, 2022

iastewar commented Dec 2, 2022

minikube-pr-bot commented Dec 3, 2022

minikube-pr-bot commented Dec 5, 2022

iastewar commented Dec 5, 2022

minikube-pr-bot commented Dec 6, 2022

iastewar commented Dec 6, 2022

spowelljr commented Dec 7, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 8, 2022

minikube-pr-bot commented Dec 9, 2022

minikube-pr-bot commented Dec 9, 2022

minikube-pr-bot commented Dec 9, 2022

minikube-pr-bot commented Dec 10, 2022

spowelljr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 14, 2022

linux-foundation-easycla bot commented Nov 25, 2022 •

edited