Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the base image in the Dockerfile to be the same as ko #34

Merged
merged 5 commits into from
Dec 16, 2022
Merged

Changed the base image in the Dockerfile to be the same as ko #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf985e2
changed dockerfile base image to the same one that ko uses
iastewar Dec 12, 2022
0d9fc31
Merge branch 'GoogleContainerTools:main' into distroless-image
iastewar Dec 12, 2022
0e54ed7
Changed the base image to ko's latest default
iastewar Dec 16, 2022
8b78a5e
Merge branch 'distroless-image' of github.com:iastewar/gcp-auth-webho…
iastewar Dec 16, 2022
5d195dc
Updated comment
iastewar Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM scratch
# base image is the same as ko's default
FROM cgr.dev/chainguard/static:latest
COPY gcp-auth-webhook /gcp-auth-webhook
ENTRYPOINT ["/gcp-auth-webhook"]
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ Use the image `gcr.io/k8s-minikube/gcp-auth-webhook` as the image for a Deployme

## Running Locally
The easiest way to run the server locally is:
* Remove `FROM scratch` in the Dockerfile and replace it with the following to ensure https requests work properly locally:
```
FROM alpine
RUN apk --no-cache add ca-certificates
```
* Modify [minikube's](https://github.com/kubernetes/minikube/blob/master/deploy/addons/gcp-auth/gcp-auth-webhook.yaml.tmpl) gcp-auth Deployment image to be `local/gcp-auth-webhook:$(VERSION)` (replace `$(VERSION)` with your version)
* Build and run minikube
* Run `eval $(path_to_minikube/minikube docker-env)` and then `make local-image` to make the image available from within minikube
Expand Down