Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the base image in the Dockerfile to be the same as ko #34

Merged
merged 5 commits into from
Dec 16, 2022

Conversation

iastewar
Copy link
Contributor

This makes the local development image the same as the production one, avoiding the cert errors that appeared with scratch.

Ideally we should be able to just use ko locally and avoid the need for a Dockerfile altogether. I haven't had a chance to look into this yet but there are flags like -L to the ko build command that might work.

@patflynn
Copy link

should this use distroless.dev/static:latest? I think that's what ko defaults to now.

@iastewar
Copy link
Contributor Author

iastewar commented Dec 13, 2022

should this use distroless.dev/static:latest? I think that's what ko defaults to now.

According to the docs, gcr.io/distroless/static:nonroot is the default. Where did you find that distroless.dev/static:latest is the default?

@patflynn
Copy link

@imjasonh
Copy link

The docs are out of date, as of v0.12 the default base image is cgr.dev/chainguard/static:latest (equivalent to distroless.dev/static:latest)

ko-build/ko#903

@iastewar
Copy link
Contributor Author

iastewar commented Dec 14, 2022

Thanks @patflynn and @imjasonh. Has the base image been changed often? If so we might as well remove the Dockerfile now and just use ko locally.

@imjasonh
Copy link

The base image has changed exactly once ever, from gcr distroless to distroless.dev, then in name only to the equivalent cgr.dev/chainguard image.

I don't expect it will change again, at least not soon.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@spowelljr spowelljr merged commit 47fb3be into GoogleContainerTools:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants