-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the base image in the Dockerfile to be the same as ko #34
Changed the base image in the Dockerfile to be the same as ko #34
Conversation
should this use distroless.dev/static:latest? I think that's what ko defaults to now. |
According to the docs, |
I think the docs are out of date. @imjasonh FYI |
The docs are out of date, as of v0.12 the default base image is |
The base image has changed exactly once ever, from gcr distroless to distroless.dev, then in name only to the equivalent cgr.dev/chainguard image. I don't expect it will change again, at least not soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
This makes the local development image the same as the production one, avoiding the cert errors that appeared with scratch.
Ideally we should be able to just use ko locally and avoid the need for a Dockerfile altogether. I haven't had a chance to look into this yet but there are flags like
-L
to theko build
command that might work.