Adds useOnlyProjectCache jib-maven-plugin configuration. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| baseCache.close(); | ||
| applicationCache.close(); | ||
| // Ensures that only one Cache is initialized if using the same directory. | ||
| if (Files.isSameFile(baseCacheDirectory, applicationCacheDirectory)) { |
There was a problem hiding this comment.
just curious, does this need to be syncrhonized or made threadsafe somehow?
There was a problem hiding this comment.
Yes, most things the codebase are designed to be thread-local and/or immutable but the CacheMetadata in a Cache is shared between threads. The only method that mutates the CacheMetadata state is CacheMetadata#addLayer, which is synchronized.
loosebazooka
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29