-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds useOnlyProjectCache jib-maven-plugin configuration. #134
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
939df10
Adds default base image layers cache directory for Caches.
coollog 028d328
Adds cache directory to CacheDirectoryNotOwnedException.
coollog 98f91a4
Adds useOnlyProjectCache jib-maven-plugin configuration.
coollog a7be1d1
Fixes BuildImageMojoTest.
coollog f4e189a
Merge branch 'master' into maven-useOnlyProjectCache
coollog 0890704
Merge branch 'master' into maven-useOnlyProjectCache
coollog ebbb547
Merge branch 'master' into maven-useOnlyProjectCache
coollog 6a97809
Fixes tests.
coollog 7c9e7b8
Fixes windows build.
coollog c3a9536
Fixes format.
coollog 72ac4ea
Merge branch 'master' into maven-useOnlyProjectCache
coollog 0f3f2f4
Merge branch 'master' into maven-useOnlyProjectCache
coollog 2ac0f96
Merge branch 'master' into maven-useOnlyProjectCache
coollog f935e43
Merge branch 'master' into maven-useOnlyProjectCache
coollog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, does this need to be syncrhonized or made threadsafe somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, most things the codebase are designed to be thread-local and/or immutable but the
CacheMetadata
in a Cache is shared between threads. The only method that mutates theCacheMetadata
state isCacheMetadata#addLayer
, which issynchronized
.