Improve entrypoint INHERIT doc for Maven #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this shows up anywhere else in our docs or examples; I could have sworn maven allowed skipping the inner tags for single-element lists. |
|
Huh, if that's the case, it's worth looking into this further. |
|
Yeah, |
|
Confirmed. Maven 3.2.5 gives the error in #2433. Let me update the PR. |
|
hrmm... we end up suggesting a less user friendly option for maven users on the latest maven though? |
chanseokoh
changed the title
|
@loosebazooka updated the doc. What do you think? |
|
I'm not sure about |
|
I like |
TadCordle
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2433.
OTOH, Gradle is OK and can take both
jib.container.entrypoint = 'INHERIT'andjib.container.entrypoint = [ 'INHERIT' ];