UPGRADE FAILED: "skaffold-helm" has no deployed releases still persists

[iirekm]

Expected behavior

When I call scaffold run in the examples/helm-deployemnt directory it should deploy.

Actual behavior

UPGRADE FAILED: "skaffold-helm" has no deployed releases
This issue was already raised and marked as 'closed' - it still persists!

Information

• Skaffold version: 1.0.1
• Helm version: 3.0.1

[iirekm]

Workaround:

deploy:
   ...
    flags:
      upgrade:
        - --install

[tejal29]

this could be related to #3400.

I was not able to re-produce this at my end. @SakrImpargo can you try the upgrade flag mentioned above to see if it fixes the issue.

[oke-py]

For helm2, the command syntax is helm get RELEASE-NAME
https://v2.helm.sh/docs/helm/#helm-get
It corresponds to this line.
https://github.com/GoogleContainerTools/skaffold/blob/release/v1.1.0/pkg/skaffold/deploy/helm.go#L186

For helm3, the command syntax changed.

$ helm get --help
...
Usage:
  helm get [command]

Available Commands:
  all         download all information for a named release
  hooks       download all hooks for a named release
  manifest    download the manifest for a named release
  notes       download the notes for a named release
  values      download the values file for a named release
...

What's more, helm get RELEASE-NAME doesn't return any error.

$ helm get skaffold-helm >/dev/null

$ echo $?
0

Therefore, isInstalled remains true and goes into this block.
https://github.com/GoogleContainerTools/skaffold/blob/release/v1.1.0/pkg/skaffold/deploy/helm.go#L207-L216

[ghost]

Yes that's exactly the issue. I explored this a bit here: #3400 (comment)

[tuananh]

Workaround:

deploy:
   ...
    flags:
      upgrade:
        - --install

is this the recommended workaround in the meantime?

[nkubala]

is this issue still present without the workaround?

[tstromberg]

I believe this was addressed by the helm3 improvements in recent releases. Please /reopen if not.

[smrutimandal]

For broken deployments, try deleting the helm release, even if the release doesn't show up in listing.

$ helm delete <release>

[jkleckner]

If this helps someone else, I think this happened when a skaffold debug ... with a helm deployer was interrupted with ctrl-C maybe twice and the helm uninstall didn't complete.

Running helm list --all-namespaces didn't show it but a helm list --all-namespaces -a did show that it was in an "uninstalling" state.

Runninig helm delete -n ns release-name cleared it up as mentioned by @smrutimandal

[filipenf]

This happens - even with the --install flag

DEBU[0029] Running command: [helm --kube-context dev upgrade testservice --install skaffold/helm/testservice --post-renderer /usr/local/bin/skaffold --namespace <REDACTED> --set <REDACTED> ... ]  subtask=0 task=Deploy
Error: UPGRADE FAILED: "testservice" has no deployed releases
TRAC[0030] logAggregator: Stop() close channel           subtask=-1 task=DevLoop
Cleaning up...

As @jkleckner mentioned, it tends to happen when the cleanup doesn't complete (ie user hits ctrl+c a second time)