HelmDeployer should detect helm version (2 or 3)

[oke-py]

Expected behavior

New function to detect helm version should be added to pkg/skaffold/deploy/helm.go.

Actual behavior

Helm version is assumed as v2.x.
Some helm command syntax changed in 3.x, and so, some skaffold function does not work as expected.

Information

This is the prerequisite for #3386 and #3387.

area/deploy
deploy/helm3

Steps to reproduce the behavior

N/A

[oke-py]

I'm trying this.

[KhaledSakr]

I think a better solution for #3386 would be to always use helm upgrade --install since that seems to be the desired behaviour anyway. We shouldn't need to reimplement something in skaffold that is already supported by helm.

[ktarplee]

This is partially implemented here

See #2142

[oke-py]

@ktarplee Thank you for information.
If I understand correctly, detecting helm version is not desired and helm3 deployer should be implemented.

[ktarplee]

I know that having a new deployed is preferred however I have not seen the argument so I have no opinion on the matter. However it seems to me that one should not require a change to skaffold.yaml if they deploy to a cluster using a different version of helm as it is still just helm. That’s my two cents, and I don’t much care which way you guys go so long as full helm 3 support comes soon.

…

Sent from my iPhone

On Jan 4, 2020, at 5:08 AM, Naoki Oketani ***@***.***> wrote: @ktarplee Thank you for information. If I understand correctly, detecting helm version is not desired and helm3 deployer should be implemented. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[tejal29]

@ktarplee Thanks. Supporting Helm3 is our high on our priority list. Sorry this taking longer.

We do want to make sure, we give users plenty of time to upgrade their app helm2 to helm3. We will change the default to helm3 as per our SLA.

[ErwinSteffens]

Any update v3 support? We love the tool, but this is a serious hurdle in adopting it.

[nkubala]

@ErwinSteffens this was fixed with #3738! we'll ship it with the v1.5.0 release.

[ErwinSteffens]

@ErwinSteffens this was fixed with #3738! we'll ship it with the v1.5.0 release.

Awesome, we will check it out!