Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm3 support to the helm deployer #3738

Merged
merged 6 commits into from Feb 27, 2020
Merged

Add helm3 support to the helm deployer #3738

merged 6 commits into from Feb 27, 2020

Conversation

tstromberg
Copy link
Contributor

Based almost entirely on @ktarplee 's work in #2900 - with some additional testing and refactoring to prepare for it's insertion.

  • Drops flags unnecessary in helm 3
  • Changes version detection to use struct output, as --short isn't supported in v2.0.0

Fixes #2142 #3438

@tstromberg tstromberg changed the title Add helm3 support Add helm3 deployer support Feb 26, 2020
@codecov
Copy link

codecov bot commented Feb 26, 2020 •
edited

Codecov Report

Merging #3738 into master will decrease coverage by 0.06%.
The diff coverage is 65%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
pkg/skaffold/deploy/helm.go 77.18% <65%> (-1.54%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@tstromberg
Copy link
Contributor Author

tstromberg commented Feb 27, 2020 •
edited

This PR assumes that #3743 is merged first to address packageChart quirks.

@tstromberg tstromberg mentioned this pull request Feb 27, 2020
Merged
nkubala
nkubala reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits but this looks great

pkg/skaffold/deploy/helm.go Outdated Show resolved Hide resolved
pkg/skaffold/deploy/helm.go Outdated Show resolved Hide resolved
@tstromberg tstromberg changed the title Add helm3 deployer support Add helm3 support to the helm deployer Feb 27, 2020
@nkubala nkubala mentioned this pull request Feb 27, 2020
Closed
@nkubala nkubala merged commit 31d771a into GoogleContainerTools:master Feb 27, 2020
@tstromberg tstromberg mentioned this pull request Feb 27, 2020
Merged
@nkubala nkubala mentioned this pull request Feb 28, 2020
Closed
@BlenderDude BlenderDude mentioned this pull request Mar 2, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support helm 3
3 participants
@tstromberg @nkubala @googlebot