Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold init thinks some python files are Dockerfiles #3484

Closed
balopat opened this issue Jan 8, 2020 · 0 comments · Fixed by #3499
Closed

skaffold init thinks some python files are Dockerfiles #3484

balopat opened this issue Jan 8, 2020 · 0 comments · Fixed by #3499
Labels
area/init good first issue Good for newcomers kind/bug Something isn't working priority/p2 May take a couple of releases

Comments

@balopat
Copy link
Contributor

balopat commented Jan 8, 2020

image

content of: src/messages/tests.py

from django.test import TestCase

# Create your tests here.
@balopat balopat added kind/bug Something isn't working priority/p2 May take a couple of releases area/init good first issue Good for newcomers labels Jan 8, 2020
spectrox added a commit to spectrox/skaffold that referenced this issue Jan 10, 2020
@spectrox
Dockerfile detector will only check files containing "Dockerfile" in …
87a6540 
…the name.

Fixes GoogleContainerTools#3484.
@spectrox spectrox mentioned this issue Jan 10, 2020
Merged
7 tasks
dgageot pushed a commit that referenced this issue Jan 15, 2020
@spectrox @dgageot
Dockerfile detector will only check files containing "Dockerfile" in …
1ac3b2a 
…the name (#3499)

* Dockerfile detector will only check files containing "Dockerfile" in the name.

Fixes #3484.

* Make filename check case-insensitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/init good first issue Good for newcomers kind/bug Something isn't working priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dockerfile detector will only check files containing "Dockerfile" in the name spectrox/skaffold
1 participant
@balopat