Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print error messages when containers can’t be started #1415

Merged
merged 1 commit into from Dec 21, 2018
Merged

Print error messages when containers can’t be started #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/skaffold/kubernetes/log.go
View file
Open in desktop
Expand Up @@ -26,11 +26,12 @@ import (
"sync/atomic"
"time"

"github.com/GoogleContainerTools/skaffold/pkg/skaffold/color"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/watch"

"github.com/GoogleContainerTools/skaffold/pkg/skaffold/color"
)

// Client is for tests
Expand Down Expand Up @@ -100,6 +101,9 @@ func (a *LogAggregator) Start(ctx context.Context) error {

for _, container := range pod.Status.ContainerStatuses {
if container.ContainerID == "" {
if container.State.Waiting != nil && container.State.Waiting.Message != "" {
color.Red.Fprintln(a.output, container.State.Waiting.Message)
}
continue
}

Expand Down