Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore defaulting to polling trigger #2228

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 6, 2019

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot added the priority/p0 Highest priority. We are actively looking at delivering it. label Jun 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #2228 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2228   +/-   ##
======================================
  Coverage    58.1%   58.1%           
======================================
  Files         188     188           
  Lines        7869    7869           
======================================
  Hits         4572    4572           
  Misses       2924    2924           
  Partials      373     373
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/dev.go 22.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d676b...7117e26. Read the comment docs.

Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shd you be reverting the whole commit here
1f5c834

@dgageot
Copy link
Contributor Author

dgageot commented Jun 6, 2019

No, the rest is ok

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 9935f9e into GoogleContainerTools:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants