Fix Monitor test #2413
Merged
Fix Monitor test #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GoogleContainerTools#2410 Also remove the unused function arguments
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
|
@corneliusweig would you mind taking a look at this PR? I'm trying to fix all known flaky tests |
|
This test was green 10 times with this PR: #2414. I'm trying 20 more runs |
|
I'm taking a look (can't assign myself). |
corneliusweig
approved these changes
Jul 5, 2019
| ctx, cancel := context.WithCancel(context.Background()) | ||
| var stopped sync.WaitGroup | ||
| stopped.Add(1) | ||
| go func() { |
There was a problem hiding this comment.
Nice, that's much simpler.
It really makes more sense to test synchronous code with a synchronous test :)
|
Thanks @corneliusweig for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2410
Also remove the unused function arguments