-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back applying labels to services deployed with helm #2568
Conversation
fa963ab
to
824e506
Compare
Codecov Report
|
449a088
to
c623982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- should we log a warning if the kubernetes version is lower than 1.11.3 and we are deploying with helm? Since we do that for kubectl version already.
I wouldn't add a warning - if someone sees the issue, we should just ask them to upgrade to 1.11.4+ |
Fixes #2379
In #965, we turned off labelling services due to kubernetes/kubernetes#68087
This bug is in the kube-controller-manager which runs on the cluster master side.
I tested this PR on my cluster with 1.11.7-gke.4 and port-forwarding for LoadBalancer type services works.
Impacted versions for this bug
As per GKE version skew policy, June 2019 release notes mention GKE will only support the three newest minor versions.
So in june end, for all node pools older than v1.11.X Google will enable node auto-upgrade and these nodes will be updated to 1.11.10-gke.5. ( we are v1.14 now)
In conclusion, i feel this is safe way to enable port-forwarding for services deployed by helm (helm2) to get in.