Remove service labeling temporarily #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
approved these changes
Sep 11, 2018
r2d4
reviewed
Sep 11, 2018
pkg/skaffold/deploy/labels.go
Outdated
| @@ -194,3 +192,11 @@ func groupVersionResource(disco discovery.DiscoveryInterface, gvk schema.GroupVe | |||
|
|
|||
| return schema.GroupVersionResource{}, fmt.Errorf("Could not find resource for %s", gvk.String()) | |||
| } | |||
|
|
|||
| func copyMap(dest, from map[string]string) { | |||
| if from != nil { | |||
There was a problem hiding this comment.
you can remove this check
ranging over a nil map should be fine, it just will iterate 0 times
https://groups.google.com/forum/#!topic/golang-nuts/2TVM3Rg8w_w
nkubala
approved these changes
Sep 11, 2018
Fixes GoogleContainerTools#959 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 43.77% 43.76% -0.02%
==========================================
Files 66 66
Lines 2764 2765 +1
==========================================
Hits 1210 1210
- Misses 1430 1431 +1
Partials 124 124
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #959