Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume string keys in helm charts #2982

Merged
merged 1 commit into from Oct 4, 2019

Conversation

hugoduncan
Copy link
Contributor

@hugoduncan hugoduncan commented Oct 3, 2019

Fixes: #2918
Description

Correctly handle integer keys when replacing values while
deploying Helm charts.

User facing changes

n/a

Before

Panic when helm chart contained integer keys.

After

Integer keys are processed without a panic.

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

  • Bug fix
    Correctly handle integer keys when replacing values in helm charts.

Correctly handle integer keys when replacing values while deploying
Helm charts.

Fixes GoogleContainerTools#2918
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hugoduncan hugoduncan changed the title Fixes #2918 Don't assume string keys in helm charts Oct 3, 2019
@hugoduncan
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 3, 2019
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Oct 3, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #2982 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/labels.go 78.57% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/namespaces.go 82.6% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/images.go 92.18% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/matcher.go 100% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/visitor.go 93.75% <100%> (-0.37%) ⬇️

@dgageot dgageot merged commit 7597c1c into GoogleContainerTools:master Oct 4, 2019
@tejal29 tejal29 mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: interface conversion: interface {} is int, not string
5 participants