Spelling

[jsoref]

Description

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

• I've selected en-US over en-GB as the majority of the words appear to favor that (especially for the handful of en-GB words I encountered) -- I can include a marker in the commit message for such words if necessary, but I haven't here.
• I try to avoid changes files that appear to be from third-party code, but I'm a (sleepy) human, if I missed some code, please let me know, I'll try to apply the same algorithm to the upstream (and drop the commits locally).

User facing changes

I don't think anything user-visible has changed, but I'm not absolutely certain.

After

If behavior changes: describe succintly the behavior after your change

Ok, this specific line in future PRs will be changed.

Next PRs.

I might offer a PR to remove misspellings from CHANGELOG.md. I know it's nice to record all changes in the changelog, but it's really frustrating when running a spelling-checker to have to actively say "oh, yes, they intentionally misspelled that word to say that they used to misspell that word". It's better for commits to only mention the correct spelling, if someone is curious, they can use history to learn all of the misspellings.

Submitter Checklist

• Includes unit tests
• Mentions any output changes.
• Adds documentation as needed: user docs, YAML reference, CLI reference.
• Adds integration tests if needed.

Reviewer Notes

• The code flow looks good.
• Unit test added.
• User facing changes look good.

[codecov]

Codecov Report

Merging #3458 into master will not change coverage.
The diff coverage is n/a.

Impacted Files	Coverage Δ
pkg/skaffold/docker/authenticators.go	0% <ø> (ø)	⬆️

[dgageot]

It's awesome. Just a few 3rd party files that I'd rather we don't edit.

[jsoref]

Hmm, somehow, I think I lost some commits. Please bear with me.
-- Commits restored, but I apparently lost my original commits, so if I need to resequence, I'll probably be unhappy.

[jsoref]

@dgageot: I've added those files to my ignores and updated the PR.

[dgageot]

@jsoref That's awesome. I'd love to run the check on each PR. Isn't that too complicated?

[jsoref]

Not terribly:
https://github.com/checkstyle/checkstyle/blob/master/.ci/test-spelling-unknown-words.sh

I'm hoping to write a version that stores the word list in a bucket for our own use...

[balopat]

This is so cool :D Thank you!