skaffold init supports Java/Buildpacks projects
#4318
Conversation
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
briandealwis,
nkubala,
tejal29 and
tstromberg
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4318 +/- ##
=======================================
Coverage 71.76% 71.76%
=======================================
Files 324 324
Lines 12477 12478 +1
=======================================
+ Hits 8954 8955 +1
Misses 2954 2954
Partials 569 569
Continue to review full report at Codecov.
|
| valid = true | ||
|
|
||
| // Java. | ||
| case "pom.xml", "build.gradle", "build.gradle.kts": |
There was a problem hiding this comment.
Could also add .mvn/extensions.xml (and jvm.config and maven.config?)
There was a problem hiding this comment.
Not sure those files are detected by our buildpacks. Do you know?
There was a problem hiding this comment.
They weren't, but … GoogleCloudPlatform/buildpacks#50 should fix that. I realize that only extensions.xml is applicable here as jvm.config and maven.config don't actually create the project object.
(We can add these separately — I don't think that PR should hold this up.)
No description provided.