Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support polyglot maven builds (no pom.xml) #50

Merged

Conversation

briandealwis
Copy link
Member

This PR adds support for building Polyglot Maven projects. Polyglot Maven allows using alternative representations for the pom.xml file, including YAML, Groovy, Scala, and more. The interpreter is pulled in via a .mvn/extensions.xml file.

An example is included in testdata/generic/java/polyglot-maven and used in the gcp/base acceptance tests.

@dgageot
Copy link
Contributor

dgageot commented Jun 17, 2020

/gcb

@lukasberger lukasberger added the ready to pull Import and run presubmit tests. label Jun 17, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 30, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@briandealwis briandealwis changed the base branch from master to main October 30, 2020 20:34
@google-cla
Copy link

google-cla bot commented Oct 30, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot removed the cla: no label Oct 30, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: yes label Oct 30, 2020
@copybara-service copybara-service bot merged commit 74987ed into GoogleCloudPlatform:main Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Import and run presubmit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants