Introduce Config interfaces #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
chanseokoh,
loosebazooka and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4598 +/- ##
=======================================
Coverage 73.40% 73.41%
=======================================
Files 345 345
Lines 13739 13739
=======================================
+ Hits 10085 10086 +1
+ Misses 3021 3020 -1
Partials 633 633
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
config-interfaces
branch
2 times, most recently
from
a4e0681
to
dc08f63
Compare
dgageot
force-pushed
the
config-interfaces
branch
from
dc08f63
to
6ce9f1a
Compare
dgageot
force-pushed
the
config-interfaces
branch
from
6ce9f1a
to
c43fb29
Compare
dgageot
force-pushed
the
config-interfaces
branch
from
c43fb29
to
94b4489
Compare
|
Let me remove those wip commits |
dgageot
force-pushed
the
config-interfaces
branch
from
94b4489
to
1f577f9
Compare
BTW we only squash merge now to not have to take care of these commit cleanups anymore. |
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
config-interfaces
branch
from
1f577f9
to
d914c30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional non-dangerous step towards getting rid of RunContext as much as possible.
It introduces a
Configinterface for each constructor that used to depend on a RunContext. This acts as a "facade" on the RunContext and can only access information by their getter, making them more read-only. This break some hard coupling that we have which is also nice.Signed-off-by: David Gageot david@gageot.net