Refactoring events to use Config interface for init #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
force-pushed
the
refactor_event_init
branch
from
03a5472
to
0243bb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #5532 +/- ##
==========================================
+ Coverage 71.32% 71.34% +0.02%
==========================================
Files 400 400
Lines 14829 14829
==========================================
+ Hits 10577 10580 +3
+ Misses 3475 3474 -1
+ Partials 777 775 -2
Continue to review full report at Codecov.
|
gsquared94
approved these changes
Mar 11, 2021
gsquared94
reviewed
Mar 11, 2021
testutil/event/helper.go
Outdated
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and |
There was a problem hiding this comment.
super nit: filename config.go instead of helper.go?
tejal29
force-pushed
the
refactor_event_init
branch
from
0243bb8
to
4200976
Compare
briandealwis
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor in prep of making code review changes suggested in #5491
Problem
Solution
Configinterface similar to Introduce Config interfaces #4598 and add methods to access fields needed.The other change in this PR is
testutil.eventpackage to avoid circular dependencies and use it everywhere in tests to initialize test.