Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flag order deterministic for helm's --setFiles #4779

Merged

Conversation

gsquared94
Copy link
Collaborator

No guaranteed order in iterating map.

Test failure: here

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #4779 into master will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4779      +/-   ##
==========================================
- Coverage   73.84%   73.84%   -0.01%     
==========================================
  Files         347      347              
  Lines       13753    13751       -2     
==========================================
- Hits        10156    10154       -2     
  Misses       2965     2965              
  Partials      632      632              
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 78.66% <90.90%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2582151...4104e65. Read the comment docs.

@gsquared94 gsquared94 changed the title Fix flaky helm UT Make flag order deterministic for helm's --setFiles Sep 14, 2020
@gsquared94 gsquared94 changed the title Make flag order deterministic for helm's --setFiles Make flag order deterministic for helm's --setFiles Sep 14, 2020
@gsquared94 gsquared94 merged commit 990b0cb into GoogleContainerTools:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants