Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alternative fix for #481 #495

Merged
merged 1 commit into from May 5, 2018
Merged

alternative fix for #481 #495

merged 1 commit into from May 5, 2018

Conversation

jstrachan
Copy link
Contributor

which uses 2 separate environment variables

adds a test to show it working

@jstrachan
alternative fix for GoogleContainerTools#481
41f2f06 
which uses 2 separate environment variables

adds a test to show it working

#fixes 481
@jstrachan jstrachan mentioned this pull request Apr 28, 2018
Closed
@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Apr 28, 2018
dlorenc
dlorenc approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this approach. Do we need to add this to the documentation anywhere?

@jstrachan jstrachan mentioned this pull request Apr 30, 2018
Closed
@jstrachan
Copy link
Contributor Author

@dlorenc agreed - I've raised a separate issue to track the docs stuff as there's a number of env vars / expressions around that need docs: #498

@dlorenc
Copy link
Contributor

dlorenc commented Apr 30, 2018

LGTM.

@dlorenc
Copy link
Contributor

dlorenc commented Apr 30, 2018

@r2d4 do you want to merge this now or after Kubecon?

@dgageot dgageot merged commit f161f18 into GoogleContainerTools:master May 5, 2018
@dgageot dgageot mentioned this pull request May 9, 2018
Closed
@afrittoli
Copy link
Contributor

Thanks! This is really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@r2d4 r2d4 Awaiting requested review from r2d4

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
kokoro:run runs the kokoro jobs on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jstrachan @dlorenc @afrittoli @dgageot @r2d4