Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent init #5186

Merged
merged 7 commits into from Jan 20, 2021

Conversation

MarlonGamez
Copy link
Contributor

Fixes #1273
Related #4915, #5037, #5141, #5155

Description
Adds the flow that handles users running commands without a skaffold config file being present.

User facing changes (remove if N/A)
If users try to run a command without a skaffold config such as skaffold dev, skaffold will tell them that no config is found, and that it is trying to make one. If it succeeds, it will prompt the user, making sure that they want to continue.

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5186 (b6c3cd0) into master (a518ce7) will increase coverage by 0.05%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5186      +/-   ##
==========================================
+ Coverage   71.81%   71.87%   +0.05%     
==========================================
  Files         387      388       +1     
  Lines       13924    14063     +139     
==========================================
+ Hits        10000    10108     +108     
- Misses       3190     3212      +22     
- Partials      734      743       +9     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/delete.go 57.14% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 56.52% <0.00%> (ø)
cmd/skaffold/app/cmd/diagnose.go 34.78% <0.00%> (ø)
cmd/skaffold/app/cmd/filter.go 25.58% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 87.50% <ø> (ø)
cmd/skaffold/app/cmd/generate_pipeline.go 61.53% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 46.42% <0.00%> (ø)
cmd/skaffold/app/cmd/test.go 46.66% <0.00%> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/runner.go 59.37% <37.03%> (-7.30%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a518ce7...b6c3cd0. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review January 6, 2021 19:07
@MarlonGamez MarlonGamez requested a review from a team as a code owner January 6, 2021 19:07
@MarlonGamez MarlonGamez marked this pull request as draft January 6, 2021 19:08
@MarlonGamez MarlonGamez marked this pull request as ready for review January 8, 2021 18:34
@gsquared94
Copy link
Collaborator

looks good. Should we add two flags:

  • one to skip the confirmation ? Would you like to continue? Yes
  • one to skip this feature and fail as before

@gsquared94 gsquared94 self-requested a review January 20, 2021 20:51
Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@IsaacPD IsaacPD merged commit 9eab6c3 into GoogleContainerTools:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transparent skaffold init
3 participants