New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transparent init #5186
Add transparent init #5186
Conversation
…fold into add-transparent-init
51bd6ea
to
29bee68
Compare
Codecov Report
@@ Coverage Diff @@
## master #5186 +/- ##
==========================================
+ Coverage 71.81% 71.87% +0.05%
==========================================
Files 387 388 +1
Lines 13924 14063 +139
==========================================
+ Hits 10000 10108 +108
- Misses 3190 3212 +22
- Partials 734 743 +9
Continue to review full report at Codecov.
|
looks good. Should we add two flags:
|
9548ada
to
312b46b
Compare
312b46b
to
b6c3cd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes #1273
Related #4915, #5037, #5141, #5155
Description
Adds the flow that handles users running commands without a skaffold config file being present.
User facing changes (remove if N/A)
If users try to run a command without a skaffold config such as
skaffold dev
, skaffold will tell them that no config is found, and that it is trying to make one. If it succeeds, it will prompt the user, making sure that they want to continue.