Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure maven connection pool TTL to avoid connection resets from stale connections #5251

Merged
merged 2 commits into from Jan 20, 2021

Conversation

briandealwis
Copy link
Member

Description
Updates Maven wrapper properties to pull down Maven 3.6.3 to ensure we have latest bug fixes.
Adds JVM command-switches to change the Maven Wagon HTTP transport's TTL to 2 minutes.

Fixes: #5248 🤞

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #5251 (3aafdbd) into master (37ed158) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5251      +/-   ##
==========================================
+ Coverage   71.86%   71.90%   +0.04%     
==========================================
  Files         388      388              
  Lines       14051    14043       -8     
==========================================
  Hits        10098    10098              
+ Misses       3207     3203       -4     
+ Partials      746      742       -4     
Impacted Files Coverage Δ
pkg/skaffold/util/cmd.go 66.66% <0.00%> (+15.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ed158...3aafdbd. Read the comment docs.

@briandealwis briandealwis merged commit ba3fe0c into GoogleContainerTools:master Jan 20, 2021
@briandealwis briandealwis deleted the mvn-conn-reset branch January 20, 2021 20:15
@briandealwis
Copy link
Member Author

Used commit-bit to fix tests — failing test is TestDebug/helm, being tracked in #5252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven builds sometimes fail with connection resets
1 participant