Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test timeout failures in TestDebug/helm #5252

Merged
merged 2 commits into from Jan 20, 2021

Conversation

briandealwis
Copy link
Member

Description
Change the integration tests WaitForDeploymentsToStablize() to wait for up to 2 minutes.

Also updates the diagnosing logging to log the command to be executed before executing the command for more accurate timestamps.

Fixes: #5249

- Set deployment timeout to 2 minutes to support tests without pods
- Log commands prior to execution for better timestamp fidelity
@briandealwis briandealwis requested a review from a team as a code owner January 20, 2021 17:09
@google-cla google-cla bot added the cla: yes label Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #5252 (a76ca45) into master (37ed158) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5252      +/-   ##
==========================================
+ Coverage   71.86%   71.90%   +0.03%     
==========================================
  Files         388      388              
  Lines       14051    14043       -8     
==========================================
- Hits        10098    10097       -1     
+ Misses       3207     3204       -3     
+ Partials      746      742       -4     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️
pkg/skaffold/util/cmd.go 66.66% <0.00%> (+15.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ed158...a76ca45. Read the comment docs.

@briandealwis
Copy link
Member Author

Hmm, this doesn't seem to be sufficient! 🤣

    debug_test.go:105: Timed out waiting for deployments [skaffold-helm] to stabilize in namespace skaffoldt9tjf

@briandealwis
Copy link
Member Author

Going to commit this since it should hopefully reduce the number of problems with the TestDebug/helm test and I hope the logs should give us more information about what's going wrong if it takes longers.

@briandealwis briandealwis merged commit 9be575b into GoogleContainerTools:master Jan 20, 2021
@briandealwis briandealwis deleted the helm-timeout branch January 20, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: TestDebug/helm time out
1 participant