Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design proposal to show user survey other than Hats #6186

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Jul 11, 2021

related to #6166

This is a design proposal to show user survey (other than Hats) to skaffold users.

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #6186 (07373b9) into master (7a8f054) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6186   +/-   ##
=======================================
  Coverage   71.09%   71.10%           
=======================================
  Files         483      483           
  Lines       21549    21549           
=======================================
+ Hits        15321    15323    +2     
+ Misses       5248     5247    -1     
+ Partials      980      979    -1     
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8f054...07373b9. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few suggestions and very minor nits.

docs/design_proposals/user_survey_hooks.md Outdated Show resolved Hide resolved
{
id: helmID,
expiresAt: time.Date(2021, time.August, 14, 00, 00, 00, 0, time.UTC),
isRelevantFn: func(cfgs []util.VersionedConfig) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also provide the command name? So for example, we could solicit for feedback on test or debug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

docs/design_proposals/user_survey_hooks.md Outdated Show resolved Hide resolved
docs/design_proposals/user_survey_hooks.md Outdated Show resolved Hide resolved
docs/design_proposals/user_survey_hooks.md Outdated Show resolved Hide resolved
docs/design_proposals/user_survey_hooks.md Outdated Show resolved Hide resolved
docs/design_proposals/user_survey_hooks.md Outdated Show resolved Hide resolved
docs/design_proposals/user_survey_hooks.md Show resolved Hide resolved
```

### How to prompt users to take user surveys

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe show an example of how the current HaTS prompt looks like, and how the proposal will look like.

docs/design_proposals/user_survey_hooks.md Show resolved Hide resolved
tejal29 and others added 2 commits July 12, 2021 09:03
Co-authored-by: Brian de Alwis <bsd@acm.org>
@tejal29 tejal29 merged commit 62a01f6 into GoogleContainerTools:master Jul 12, 2021
@tejal29 tejal29 deleted the user_survey_dd branch July 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants