Add Dir config field to ko builder
#6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/design_proposals/ko-builder.md
Outdated
| // Dir is the directory where the `go` tool will be run. | ||
| // The value is a directory path relative to the `context` directory. | ||
| // If empty, the `go` tool will run in the `context` directory. | ||
| // Example: `my-go-mod-is-in-this-dir` |
There was a problem hiding this comment.
I hoped to come up with a more realistic example, but I can't think of anything that is any better (live-at-head, compat-go114)
There was a problem hiding this comment.
Those are better examples, I've updated the doc.
The `Dir` config field supports users who have directory layouts where the Go sources and `go.mod` file are in subdirectories of the `context` directory. The value of `Dir` is a directory path relative to the `context` directory, and it specifies the directory where `go build` is run. This change also moves forward some of the additional ko builder flags in the implementation plan, since the relevant ko PRs have been merged.
Also change example ko builder `Dir` config values.
halvards
force-pushed
the
ko-config-dir
branch
from
a1c8155
to
0cf3ab4
Compare
Codecov Report
@@ Coverage Diff @@
## main #6496 +/- ##
==========================================
- Coverage 70.43% 70.41% -0.02%
==========================================
Files 515 515
Lines 23127 23127
==========================================
- Hits 16289 16286 -3
- Misses 5780 5783 +3
Partials 1058 1058
Continue to review full report at Codecov.
|
briandealwis
approved these changes
Aug 30, 2021
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Sep 6, 2021
**Description** Container images built by ko have the [author](https://github.com/opencontainers/image-spec/blob/main/config.md#properties) property set to the value [`github.com/google/ko`](https://github.com/google/ko/blob/v0.8.3/pkg/build/gobuild.go#L610). Skaffold debug can use this property to detect a Go runtime artifact. This feature can be used for images built using Skaffold's ko builder (when ready), and for images build using ko via a custom build (usable now). **Tracking**: GoogleContainerTools#6041 **Related**: GoogleContainerTools#6563 **Context**: GoogleContainerTools#6496 (comment)
This was referenced Sep 6, 2021
tejal29
pushed a commit
that referenced
this pull request
Sep 8, 2021
**Description** Container images built by ko have the [author](https://github.com/opencontainers/image-spec/blob/main/config.md#properties) property set to the value [`github.com/google/ko`](https://github.com/google/ko/blob/v0.8.3/pkg/build/gobuild.go#L610). Skaffold debug can use this property to detect a Go runtime artifact. This feature can be used for images built using Skaffold's ko builder (when ready), and for images build using ko via a custom build (usable now). **Tracking**: #6041 **Related**: #6563 **Context**: #6496 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Dirconfig field supports users who have directory layouts where the Go sources andgo.modfile are in subdirectories of thecontextdirectory.The value of
Diris a directory path relative to thecontextdirectory, and it specifies the directory wherego buildis run.This change also moves forward some of the additional ko builder flags in the implementation plan, since the relevant ko PRs have been merged.
Context: #6054 (comment)
Tracking: #6041
Related: #6437 #6447