Ko builder: Add Env, Flags, and Ldflags config #6546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following config fields to the ko artifact builder schema: - `Env`, for environment variables to set during image build, e.g. `GOPRIVATE`. - `Flags`, for arguments to `go build`, e.g., `-trimpath`. - `Ldflags`, for linker flags such as `-s`, and `-w`. Bumps the ko version to bring in support for these build config fields.
Codecov Report
@@ Coverage Diff @@
## main #6546 +/- ##
==========================================
+ Coverage 70.42% 70.44% +0.01%
==========================================
Files 515 515
Lines 23144 23155 +11
==========================================
+ Hits 16300 16312 +12
+ Misses 5786 5784 -2
- Partials 1058 1059 +1
Continue to review full report at Codecov.
|
briandealwis
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following config fields to the ko artifact builder schema:
Env, for environment variables to set during image build, e.g.GOPRIVATE.Flags, for arguments togo build, e.g.,-trimpath.Ldflags, for linker flags such as-s, and-w.Bumps the ko version to bring in support for these build config fields.
Tracking: #6041
Related: #6496