Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change error to warning for build platform mismatch with cluster node platform #7402

Merged
merged 1 commit into from May 13, 2022

Conversation

gsquared94
Copy link
Collaborator

@gsquared94 gsquared94 commented May 13, 2022

Fixes: #7355

Description

minikube and docker-desktop on Apple M1 report their cluster node types as linux/arm64 but they can run linux/amd64 images using qemu binfmt_misc extensions. So we change this error condition to a warning message instead.
User facing changes (remove if N/A)

Users can force build for specific platforms using --platform flag even if it doesn't match the kubernetes cluster node types.

Follow up Work

Cherrypick this to v1 branch before v1.39.0 release.

mismatch with cluster node platform
@gsquared94 gsquared94 marked this pull request as ready for review May 13, 2022 00:44
@gsquared94 gsquared94 requested a review from a team as a code owner May 13, 2022 00:44
@gsquared94 gsquared94 added this to the v1.39.0 milestone May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #7402 (288e29b) into main (290280e) will decrease coverage by 3.86%.
The diff coverage is 55.51%.

@@            Coverage Diff             @@
##             main    #7402      +/-   ##
==========================================
- Coverage   70.48%   66.62%   -3.87%     
==========================================
  Files         515      566      +51     
  Lines       23150    27150    +4000     
==========================================
+ Hits        16317    18088    +1771     
- Misses       5776     7761    +1985     
- Partials     1057     1301     +244     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 50.00% <0.00%> (-3.85%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <12.50%> (-4.72%) ⬇️
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 55.93% <38.88%> (-20.54%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
... and 294 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tejal29 tejal29 merged commit aeaf2c6 into GoogleContainerTools:main May 13, 2022
gsquared94 added a commit to gsquared94/skaffold that referenced this pull request May 13, 2022
tejal29 pushed a commit that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to force deployment platform
2 participants