fix: default to builder supported platform with a warning instead of erroring #7659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Skaffold with the
buildpacks
builder on an M1 Mac against theminikube
cluster, there are two scenarios:User specifies the platform explicitly using
--platform=linux/amd64
.This was previously erroring out, due to Skaffold disallowing builds for a platform that doesn't match the active kubernetes cluster nodes. However, local clusters like
minikube
anddocker-desktop
on Apple M1 can runlinux/amd64
images usingqemu binfmt_misc extensions
. So we changed this error condition to a warning message instead in fix: change error to warning for build platform mismatch with cluster node platform #7402.Users don't specify platform explicitly
In this case Skaffold selects the platform
linux/arm64
based on the active kubernetes cluster node platform type. However, sincebuildpacks
doesn't support building for this platform the build fails. We instead change this to a warning message and select the builder supported platforms instead. This is fixed in this PR.