-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Tutorial: Go coverage profiles for e2e tests #8558
docs: Tutorial: Go coverage profiles for e2e tests #8558
Conversation
This also required upgrading GolangCI-Lint, which in turn found an unused field that appears to have previously gone undetected. Related: GoogleContainerTools#8558
This also required upgrading GolangCI-Lint, which in turn found an unused field that appears to have previously gone undetected. Related: #8558
Thanks for the PR here Halvard! Can you rebase this? Also it seems the |
c124558
to
5ade5aa
Compare
New tutorial that shows how to use Skaffold post-deploy hooks to collect coverage profiles from integration tests, often called end-to-end tests, of Go applications. This takes advantage of new functionality in Go 1.20: https://go.dev/testing/coverage/ I couldn't find a way to include files from the `examples` directory in the tutorial Markdown, so instead of duplicating files from the example in the `docs-v2` directory, the tutorial instead points readers to the files in the `examples` directory.
5ade5aa
to
2041501
Compare
Codecov Report
@@ Coverage Diff @@
## main #8558 +/- ##
==========================================
- Coverage 70.48% 64.45% -6.04%
==========================================
Files 515 617 +102
Lines 23150 31168 +8018
==========================================
+ Hits 16317 20088 +3771
- Misses 5776 9575 +3799
- Partials 1057 1505 +448
... and 406 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
New tutorial that shows how to use Skaffold post-deploy hooks to collect coverage profiles from integration tests, often called end-to-end tests, of Go applications.
This takes advantage of new functionality in Go 1.20: https://go.dev/testing/coverage/
I couldn't find a way to include files from the
examples
directory in the tutorial Markdown, so instead of duplicating files from the example in thedocs-v2
directory, the tutorial instead points readers to the files in theexamples
directory.