Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use Go 1.20 in GitHub Actions workflows #8691

Merged

Conversation

halvards
Copy link
Collaborator

@halvards halvards commented Apr 20, 2023

This also required upgrading GolangCI-Lint, which in turn found an unused field that appears to have previously gone undetected.

Related: #8558

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #8691 (88523e3) into main (290280e) will decrease coverage by 6.01%.
The diff coverage is 54.27%.

@@            Coverage Diff             @@
##             main    #8691      +/-   ##
==========================================
- Coverage   70.48%   64.48%   -6.01%     
==========================================
  Files         515      616     +101     
  Lines       23150    30985    +7835     
==========================================
+ Hits        16317    19980    +3663     
- Misses       5776     9505    +3729     
- Partials     1057     1500     +443     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 407 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This also required upgrading GolangCI-Lint, which in turn found an
unused field that appears to have previously gone undetected.

Related: GoogleContainerTools#8558
@ericzzzzzzz ericzzzzzzz merged commit 2188f86 into GoogleContainerTools:main Apr 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants