Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set value file for render #8647

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Apr 6, 2023

Fixes: #8594

Description

  • add --set-value-flag to skaffold render command for users to provide a .env format key-value pair file to set their manifests templated fields.
  • move ParseEnvVariablesFromFile method from verify util to skaffold pkg util as this can be a utility func across skaffold project.

Test Plan

  • integration tests.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #8647 (edb086e) into main (290280e) will decrease coverage by 6.33%.
The diff coverage is 54.47%.

@@            Coverage Diff             @@
##             main    #8647      +/-   ##
==========================================
- Coverage   70.48%   64.15%   -6.33%     
==========================================
  Files         515      614      +99     
  Lines       23150    30808    +7658     
==========================================
+ Hits        16317    19766    +3449     
- Misses       5776     9560    +3784     
- Partials     1057     1482     +425     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 394 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review April 6, 2023 12:10
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 2b3c15e into GoogleContainerTools:main Apr 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants