Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change util pkg import to use ParseEnvVariablesFromFile #8700

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

renzodavid9
Copy link
Contributor

Related PRs:

Description
In #8647 we changed the pkg where the ParseEnvVariablesFromFile function is defined. At the same time we had #8681 where we are consuming the ParseEnvVariablesFromFile from the previous pkg. After merging all the changes, now we have to update the util pkg in the ActionsRunner.

@renzodavid9 renzodavid9 marked this pull request as ready for review April 21, 2023 14:40
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #8700 (9bf11b3) into main (290280e) will decrease coverage by 6.02%.
The diff coverage is 54.27%.

@@            Coverage Diff             @@
##             main    #8700      +/-   ##
==========================================
- Coverage   70.48%   64.46%   -6.02%     
==========================================
  Files         515      615     +100     
  Lines       23150    30994    +7844     
==========================================
+ Hits        16317    19981    +3664     
- Misses       5776     9510    +3734     
- Partials     1057     1503     +446     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 406 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 merged commit 0b4bb63 into GoogleContainerTools:main Apr 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants