Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logic to create a new ActionsRunner #8681

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

renzodavid9
Copy link
Contributor

Fixes: #8519

Description
This PR adds the logic to create a new actions runner reading the configuration from customActions stanza in the skaffold.yaml file.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #8681 (ae14c2d) into main (290280e) will decrease coverage by 6.41%.
The diff coverage is 54.02%.

@@            Coverage Diff             @@
##             main    #8681      +/-   ##
==========================================
- Coverage   70.48%   64.08%   -6.41%     
==========================================
  Files         515      623     +108     
  Lines       23150    31178    +8028     
==========================================
+ Hits        16317    19979    +3662     
- Misses       5776     9698    +3922     
- Partials     1057     1501     +444     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 403 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Apr 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Apr 18, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review April 19, 2023 16:58
Comment on lines -33 to -34
var _ runner.ActionsRunner = Runner{}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing due to cyclic dependency between runner pkg and actions pkg.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 7ff0531 into GoogleContainerTools:main Apr 19, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Actions] Add logic to instantiate Actions from customActions stanza
4 participants