-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logic to create a new ActionsRunner #8681
feat: logic to create a new ActionsRunner #8681
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8681 +/- ##
==========================================
- Coverage 70.48% 64.08% -6.41%
==========================================
Files 515 623 +108
Lines 23150 31178 +8028
==========================================
+ Hits 16317 19979 +3662
- Misses 5776 9698 +3922
- Partials 1057 1501 +444
... and 403 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
var _ runner.ActionsRunner = Runner{} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing due to cyclic dependency between runner pkg and actions pkg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes: #8519
Description
This PR adds the logic to create a new actions runner reading the configuration from
customActions
stanza in theskaffold.yaml
file.