feat: configure verify and exec commands to emit metrics #9013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9013 +/- ##
==========================================
- Coverage 70.48% 63.62% -6.86%
==========================================
Files 515 624 +109
Lines 23150 31934 +8784
==========================================
+ Hits 16317 20319 +4002
- Misses 5776 10085 +4309
- Partials 1057 1530 +473
... and 416 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
plumpy
approved these changes
Aug 14, 2023
renzodavid9
changed the title
renzodavid9
added a commit
that referenced
this pull request
Sep 7, 2023
* feat: configure render, verify, and exec commands to emit metrics * fix: remove render command from tracking due to corrupted output data
renzodavid9
added a commit
that referenced
this pull request
Sep 8, 2023
* feat: configure verify and exec commands to emit metrics (#9013) * feat: configure render, verify, and exec commands to emit metrics * fix: remove render command from tracking due to corrupted output data * feat: enable skaffold render to track telemetry (#9020) * feat: making survey, update, and tracking messages to print to stderr instead of stdout * feat: enable `skaffold render` to track telemetry * feat: remove tests checking if a stadout is set, now we are using stderr * feat: make stderr used to print survey, update, and metricts promp, coloreable to keep same behaviour as stdin * feat: removing IsStdout function and related tests * fix: change baseRef to point to v2.6 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR configures the
verifyandexeccommands to start emitting metrics when are used. Right now the logic to make a command to emit metrics is related with the logic that decides if a command should show the Skaffold survey.Follow-up work
Will follow-up with a PR to track the
skaffold rendercommand.