feat: enable skaffold render to track telemetry #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renzodavid9
force-pushed
the
tracking-render-command
branch
from
b0fc468
to
337f97c
Compare
renzodavid9
changed the title
Codecov Report
@@ Coverage Diff @@
## main #9020 +/- ##
==========================================
- Coverage 70.48% 63.62% -6.86%
==========================================
Files 515 624 +109
Lines 23150 31934 +8784
==========================================
+ Hits 16317 20318 +4001
- Misses 5776 10084 +4308
- Partials 1057 1532 +475
... and 419 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…oloreable to keep same behaviour as stdin
renzodavid9
force-pushed
the
tracking-render-command
branch
from
a30634b
to
43278b8
Compare
renzodavid9
commented
Aug 17, 2023
| @@ -53,9 +52,6 @@ func ShouldDisplayMetricsPrompt(configfile string) bool { | |||
| } | |||
|
|
|||
| func DisplayMetricsPrompt(configFile string, out io.Writer) error { | |||
| if isStdOut(out) { | |||
There was a problem hiding this comment.
I was checking the idea behind this condition, it was checking if the given io.Writer was a stdout, but from my understanding in the code, we were always sending an stdout, so it was always true, and I didn't see other place where we were using this function or sending other type of io.Writer, so I removed the condition + function completely 😅 . Let me know if you see a case I'm not taking into account where this condition can be false.
ericzzzzzzz
approved these changes
Aug 17, 2023
renzodavid9
added a commit
that referenced
this pull request
Sep 7, 2023
* feat: making survey, update, and tracking messages to print to stderr instead of stdout * feat: enable `skaffold render` to track telemetry * feat: remove tests checking if a stadout is set, now we are using stderr * feat: make stderr used to print survey, update, and metricts promp, coloreable to keep same behaviour as stdin * feat: removing IsStdout function and related tests
renzodavid9
added a commit
that referenced
this pull request
Sep 8, 2023
* feat: configure verify and exec commands to emit metrics (#9013) * feat: configure render, verify, and exec commands to emit metrics * fix: remove render command from tracking due to corrupted output data * feat: enable skaffold render to track telemetry (#9020) * feat: making survey, update, and tracking messages to print to stderr instead of stdout * feat: enable `skaffold render` to track telemetry * feat: remove tests checking if a stadout is set, now we are using stderr * feat: make stderr used to print survey, update, and metricts promp, coloreable to keep same behaviour as stdin * feat: removing IsStdout function and related tests * fix: change baseRef to point to v2.6 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #9013
Description
This PR configures the
skaffold rendercommand to start tracking telemetry data when it is used. Currently the logic for emitting metrics is related to the logic for displaying the Skaffold survey URL, the opt-out message, and the version upgrade. These messages were corrupting the output when used, e.g, likeskaffold render > manifest.yaml, due to everything was printed using stdout. Now we are changing from stdout to stderr to print those messages.