Alignment panel fix for single element #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndev1991
requested review from
barklund,
dvoytenko and
swissspidy
as code owners
|
Size Change: +46 B (0%) Total Size: 821 kB
ℹ️ View Unchanged
|
swissspidy
reviewed
Apr 14, 2020
barklund
suggested changes
Apr 14, 2020
There was a problem hiding this comment.
It doesn't actually work for me.
Also, this would be a good occasion to add a full unit test of this panel with all sorts of elements, sizes and positions. The actual alignment handlers in the custom hook should be tested independently from the main panel (simply testing that it invokes the handlers properly).
|
@barklund Added tests for panel and the custom hooks. |
barklund
reviewed
Apr 16, 2020
swissspidy
approved these changes
Apr 20, 2020
obetomuniz
added a commit
that referenced
this pull request
Apr 20, 2020
* master: (30 commits) Update list of Google Fonts (#1272) Exclude template assets from plugin bundle for now (#1267) Alignment panel fix for single element (#1193) Bump polished from 3.5.1 to 3.5.2 (#1262) Bump eslint-plugin-testing-library from 3.0.3 to 3.0.4 (#1264) Bump lint-staged from 10.1.4 to 10.1.6 (#1263) Bump babel-jest from 25.3.0 to 25.4.0 (#1265) Bump jest from 25.3.0 to 25.4.0 (#1266) Removed unneeded init code Update MultiPartPill to use css power Updated SVGs to use currentColor Fixed typos Template Detail: Updated header and added left/right controls use thumbnail size from theme Dashboard: Remove circular imports from dashboard app (#1256) Bump lint-staged from 10.1.3 to 10.1.4 (#1257) fix popover layout fix dropdown alignment removes new line for buttons no boolean in proptypes ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246
For single selection, alignment should work based on page.