Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude template assets from plugin bundle for now #1267

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

swissspidy
Copy link
Collaborator

The images for the travel template are quite large, even after compression. The plugin bundle is currently over 11MB.

Since templates aren't fully implemented yet, let's omit them from the plugin bundle for now to avoid issues with the ZIP file being too large to upload.

@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Apr 20, 2020
@swissspidy swissspidy requested a review from miina April 20, 2020 08:19
@swissspidy swissspidy mentioned this pull request Apr 20, 2020
3 tasks
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 822 kB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.04 kB 0 B
assets/css/stories-dashboard.css 3 kB 0 B
assets/js/edit-story.js 445 kB 0 B
assets/js/stories-dashboard.js 370 kB 0 B

compressed-size-action

Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swissspidy swissspidy merged commit e4c71f9 into master Apr 20, 2020
@swissspidy swissspidy deleted the fix/templates-in-bundle branch April 20, 2020 11:57
obetomuniz added a commit that referenced this pull request Apr 20, 2020
* master: (30 commits)
  Update list of Google Fonts (#1272)
  Exclude template assets from plugin bundle for now (#1267)
  Alignment panel fix for single element (#1193)
  Bump polished from 3.5.1 to 3.5.2 (#1262)
  Bump eslint-plugin-testing-library from 3.0.3 to 3.0.4 (#1264)
  Bump lint-staged from 10.1.4 to 10.1.6 (#1263)
  Bump babel-jest from 25.3.0 to 25.4.0 (#1265)
  Bump jest from 25.3.0 to 25.4.0 (#1266)
  Removed unneeded init code
  Update MultiPartPill to use css power
  Updated SVGs to use currentColor
  Fixed typos
  Template Detail: Updated header and added left/right controls
  use thumbnail size from theme
  Dashboard: Remove circular imports from dashboard app (#1256)
  Bump lint-staged from 10.1.3 to 10.1.4 (#1257)
  fix popover layout
  fix dropdown alignment
  removes new line for buttons
  no boolean in proptypes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants