Dashboard: Remove elements dependency #12237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Group: WordPress
swissspidy
requested review from
timarney,
spacedmonkey,
barklund,
miina and
merapi
|
Plugin builds for 1475613 are ready 🛎️!
|
|
Size Change: +1.4 kB (0%) Total Size: 2.68 MB
ℹ️ View Unchanged
|
|
I wonder why the increase 🤔 |
Just looking at this myself. I think it because |
|
assets/js/wp-story-editor.js being 1.34MB seems like very big. I wonder if we should look into breaking this up. I am little bit worried about the editor loading. |
spacedmonkey
approved these changes
Sep 7, 2022
|
Dashboard and editor have a common bundle for shared code. The main reason is the stickers package, which is a dependency of With this PR, stickers are no longer included for the dashboard and thus no longer in the common bundle but only in the editor bundle. So that all makes sense. There is already a ticket to optimize the way stickers are included, see #11973 See also #11972 for the masks package |
This was referenced Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We do not render stories or templates in the dashboard anymore. We just display preview images. So there's no need for us to actually register elements.
Summary
Removes dependencies on
elementsandelement-libraryfrom the dashboard package.This should improve bundles a bit.
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #